Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add exponential and constant backoff function #416

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Jul 19, 2024

  • Implement the same backoff function as in the hcloud-go libary
  • Preparation work to change the retry backoff function to use an exponential backoff interval.
  • Rename PollIntervalFunction to BackoffFunction, as it is not only used for polling.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.94%. Comparing base (49d5d4f) to head (638da80).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
hcloud/_client.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   92.94%   92.94%   -0.01%     
==========================================
  Files          64       64              
  Lines        2878     2891      +13     
==========================================
+ Hits         2675     2687      +12     
- Misses        203      204       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hcloud/_client.py Show resolved Hide resolved
@jooola jooola merged commit fe7ddf6 into main Jul 22, 2024
10 checks passed
@jooola jooola deleted the backoff_functions branch July 22, 2024 13:34
jooola pushed a commit that referenced this pull request Jul 25, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](v2.0.1...v2.1.0)
(2024-07-25)


### Features

* add exponential and constant backoff function
([#416](#416))
([fe7ddf6](fe7ddf6))
* deprecate `ServerType` `included_traffic` property
([#423](#423))
([3d56ac5](3d56ac5))
* use exponential backoff when retrying requests
([#417](#417))
([f306073](f306073))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants